Drivers: i2c: target eeprom extra api #96918
Open
+87
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some use cases it can be interesting to know when the eeprom has been written to by the I2C host (E.G. once a stop has been received after a write transaction), so add a "changed" callback. Multiple EEPROM instances are supported, so pass the device as argument to the callback. Signed-off-by: Peter Korsgaard <[email protected]>
For some use cases it can be interesting to know how big the EEPROM is, so add a getter for it. Signed-off-by: Peter Korsgaard <[email protected]>
The current functions to access the EEPROM data are not ideal, E.G.: - eeprom_target_program() is hard coded to write to the beginning of the EEPROM data - eeprom_target_read() reads a single byte, so large overhead and external buffering to access the entire data So as an alternative, simply add a getter for the data. Signed-off-by: Peter Korsgaard <[email protected]>
It is not very handy that the EEPROM stops responding after 1 second, so drop that. Signed-off-by: Peter Korsgaard <[email protected]>
And show the usages of the new _get_size() / _get_data() getters. Signed-off-by: Peter Korsgaard <[email protected]>
|
JarmouniA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some use cases it can be interesting to know when the eeprom has been written to by the I2C host (E.G. once a stop has been received after a write transaction), so add a "changed" callback.
The existing API for accessing the EEPROM data is not ideal, so add getters for the size and data instead and update the sample the use the new APIs